feat: add /aidd-pr skill, rename /aidd-requirements, add eval infrastructure#168
feat: add /aidd-pr skill, rename /aidd-requirements, add eval infrastructure#168ericelliott wants to merge 30 commits intomainfrom
Conversation
- Add ai/skills/aidd-pr/SKILL.md with 6-step PR triage process - Add ai/skills/aidd-pr/README.md with usage documentation - Add ai/commands/aidd-pr.md command shortcut - Update AGENTS.md Task Index with 'review pull request => /aidd-pr' - Regenerate index.md files to include new skill and command The /aidd-pr skill enables agents to: 1. Fetch PR details and review comments via gh CLI 2. Identify already-addressed comments and present for approval 3. Resolve approved conversations via GitHub GraphQL API 4. Validate remaining issues against current source 5. Generate focused /aidd-fix delegation prompts per issue 6. Optionally dispatch prompts to sub-agents Closes #166
|
@janhesters @ianwhitedeveloper any idea why the AI tests are failing? |
Remove the 6-step SudoLang elaboration (Steps 1–6, the pipeline line, and the previous Constraints/Commands blocks). Insert the verbatim prompt from issue #166 directly after the Competencies block, preserving the frontmatter and preamble (role line + Competencies) unchanged.
…ements, add unit/e2e distinction
…s for tool-calling skills
…delegation - Add ai/skills/aidd-parallel/SKILL.md with two commands: /aidd-parallel [--branch <branch>] <tasks> — generates one /aidd-fix delegation prompt per task, wrapped in a markdown codeblock with nested codeblocks indented, targeting the supplied branch directly /aidd-parallel delegate — builds file list + mermaid dep graph, sequences prompts by dependency order, and dispatches sub-agent workers - Add ai/skills/aidd-parallel/README.md with usage and workflow docs - Add ai/commands/aidd-parallel.md as an invokable command entry point - Add ai-evals/aidd-parallel/ with prompt-generation-test.sudo eval and fixtures - Update ai/skills/aidd-pr/SKILL.md to delegate prompt generation to /aidd-parallel and remove the inner Constraints block that now belongs in /aidd-parallel - Add /aidd-parallel to the Commands block in ai/skills/aidd-please/SKILL.md - Regenerate ai/ index files
…egration - Add ai/skills/aidd-riteway-ai/SKILL.md with 7 rules for writing correct riteway ai prompt evals for multi-step tool-calling flows - Add ai/commands/aidd-riteway-ai.md command file - Add unit tests covering frontmatter, rule content, command, and aidd-please integration (12 tests, all passing) - Add /aidd-riteway-ai to Commands block in ai/skills/aidd-please/SKILL.md - Regenerate ai/ index files - Include pending eval fixes for aidd-pr step-1 and greet fixture
|
@cursor please /review |
|
That's the root cause. The However, the Summary for the PR: The CI The question for @ericelliott/@janhesters/@ianwhitedeveloper: does the CI Claude account need its quota refreshed, or does the eval job need to be made non-blocking ( |
Add a test to lib/exports.test.js that verifies README.md references the renamed ai/skills/aidd-requirements/README.md path and does not contain the old broken ai/skills/aidd-functional-requirements/README.md link.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c3b7eda. Configure here.
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ai-eval-responses | ||
| path: ai-evals/*.responses.md |
There was a problem hiding this comment.
Artifact upload glob misses subdirectory response files
Medium Severity
The artifact upload path ai-evals/*.responses.md only matches files directly in the ai-evals/ directory, but all .sudo eval files live in subdirectories (ai-evals/aidd-pr/, ai-evals/aidd-parallel/, ai-evals/aidd-review/). Since --save-responses generates response files alongside the .sudo inputs, the glob never matches any responses. The path likely needs to be ai-evals/**/*.responses.md to capture files in subdirectories.
Reviewed by Cursor Bugbot for commit c3b7eda. Configure here.
|
|
||
| fix bug => /aidd-fix | ||
| review pull request => /aidd-pr`, | ||
| keywords: ["Task Index"], |
There was a problem hiding this comment.
Task Index append section uses wrong heading level
Medium Severity
The new Task Index entry in directiveAppendSections uses a ## heading, while every other entry in the array uses ###. When appendDirectives appends missing sections for upgrading users, they're nested under the ## AIDD Agent Directives (Auto-appended) wrapper. The ## heading makes Task Index appear as a sibling of the wrapper rather than a child, breaking the document hierarchy that all other append sections follow.
Reviewed by Cursor Bugbot for commit c3b7eda. Configure here.
- Sub-agent isolation via /aidd-parallel delegate - Pipeline decomposed into effect and thinking subcommands - --output flag for arbitrary artifact types - Deterministic criteria auto-testing via Bun CLI - Blocked on PR #168 (aidd-parallel) Co-authored-by: Eric Elliott <support@paralleldrive.com>
…endencies epic - Add PR #94 split plan: /aidd-rtc (3 files, zero deps), /aidd-upskill (11 files) - Add triage tasks for modified existing skills and infrastructure files - Update merge order: rtc → pipeline → parallel → pr → evals → upskill → genesplice - Document design decisions: parallel delegate is canonical, /aidd-delegate superseded - Split PR #168 into parallel, pr, and eval infrastructure tasks - Split PR #179: only /aidd-pipeline needed, /aidd-delegate excluded Co-authored-by: Eric Elliott <support@paralleldrive.com>
Concurrent dispatch + delegation skill extracted from PR #168. Includes the delegate subcommand, prompt generation, evals, and epic.
Concurrent dispatch + delegation skill extracted from PR #168. Includes the delegate subcommand, prompt generation, evals, and epic.




Skill Split Notes
/aidd-parallel(w/ delegate)/aidd-pr/aidd-requirements/aidd-riteway-aiSummary
Implements #166 and related housekeeping. Rebased on v3.0.0.
Changes
/aidd-prskillai/skills/aidd-pr/SKILL.md— triage PR review comments, resolve addressed threads, delegate to/aidd-parallelai/skills/aidd-pr/README.md— man-page style referenceai/commands/aidd-pr.md— command shortcut/aidd-parallelskillai/skills/aidd-parallel/SKILL.md— generate/aidd-fixdelegation prompts per task;/aidd-parallel delegatebuilds a mermaid dep graph and dispatches in dependency orderai/skills/aidd-parallel/README.md— man-page style referenceai/commands/aidd-parallel.md— command shortcut/aidd-requirementsrenameai/skills/aidd-requirements/— renamed fromaidd-functional-requirements, includes man-page READMEaidd-task-creator,docs/learn-aidd-framework.mdai/commands/aidd-requirements.md— new command file/aidd-riteway-aiskillai/skills/aidd-riteway-ai/SKILL.md— 7-rule guide for writing correct.sudoprompt evals for multi-step tool-calling flowsai/skills/aidd-riteway-ai/README.md— man-page style referenceai/commands/aidd-riteway-ai.md— command shortcutai/skills/aidd-riteway-ai/riteway-ai.test.js— Vitest unit testsDiscovery
ai/skills/aidd-please/SKILL.md— all three new commands added to Commands blockAGENTS.md—review pull request => /aidd-pradded to Task Indexai/skills/index.md— regenerated with new bullet format; includes all four new skillsEvals
ai-evals/aidd-pr/step-1-triage-test.sudo— tests observable triage reasoning (T_02 addressed, T_01 remaining)ai-evals/aidd-pr/step-2-delegation-test.sudo— tests delegation prompt for T_01 only (consistent with step-1 output)ai-evals/aidd-parallel/prompt-generation-test.sudo— tests/aidd-parallelprompt outputCI
.github/workflows/ai-eval.yml— new dedicated workflow: daily at 8am UTC, path-filtered onai-evals/**,continue-on-error: true.github/workflows/test.yml—ai-evaljob removed (now inai-eval.yml)package.json—test:ai-evalnow globsai-evals/**/*-test.sudoinstead of a hardcoded pathPlanned epics
tasks/aidd-parallel-skill-epic.mdtasks/aidd-riteway-ai-skill-epic.mdtasks/ai-eval-ci-epic.md